-
Notifications
You must be signed in to change notification settings - Fork 129
Conversation
…ature/move-to-pyside2
Modifications made:
Global note
|
PySide2 version is now specified in https://pip.pypa.io/en/stable/cli/pip_install/#requirement-specifiers |
this seems to be bug in patchelf tool: NixOS/patchelf#230 Solved, but not released (and I doubt it will ever be on centos 7). Another tool we need to build from sources. |
Is it bug related to PySide2? Or we just find that out with this PR? |
TODO Note: Check centos yum install requirements... (I've added more than needed) |
This now correctly builds and run with docker. Unfortunately multiple hacks were used to fight wrong GLIBC versions on linux: That problem is caused by new setuptools - this package is dependency of poetry itself and is automatically pulled to created environment. When Cx_Freeze is installed with that new version of setuptools, it will compile its stub executables and link them with wrong version of GLIBC (not available on Centos 7). So when finally OpenPype is build, those stubs are used for To achieve this, it was necessary to get to values specified in
|
I've tested as much as I could on windows in multiple hosts. all looking good. |
Not related to this changes. Seems like is missing last develop merge... |
if not app: | ||
app = QtWidgets.QApplication([]) | ||
|
||
starter = PypeTrayStarter(app) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local variable 'starter' is assigned to but never used
Photoshop/AE on Mac OS: when launching on task, another OpenPype icon appears in task bar, Photoshop/AE won't start and console displays:
|
This PR is switching PyQt5 for PySide2. It is removing it from
pyproject.toml
so it is no longer managed by poetry (poetry doesn't support installing to custom locations yet (python-poetry/poetry#1937)). PySide2 and its dependencies (shiboken2) are installed to/vendor/python
by./tools/fetch_thirdparty_libs.ps1|sh
. You can add this directory tosys.path
using following piece of code before importing Qt.py:Steps to make the switch:
.venv
./tools/create_env.ps1|sh
./tools/fetch_thirdparty_libs.ps1|sh
Instead of 1) and 2) you can manually delete PyQt5 stuff from
.venv
Close #1676
Tested in hosts:
[cuID:yjx9ec]